From: Chen Hanxiao <chenhanxiao@gmail.com>
Date: Sat, 22 Oct 2016 09:49:38 +0000 (+0800)
Subject: qemu: Forbid pinning vCPUs for TCG domain
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=8b035c84d8a7362a87a95e6114b8e7f959685ed9;p=libvirt.git

qemu: Forbid pinning vCPUs for TCG domain

We don't support cpu pinning for TCG domains because QEMU runs them in
one thread only.  But vcpupin command was able to set them, which
resulted in a failed startup, so make sure that doesn't happen.

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 3f57a9fee0..817c567836 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5189,6 +5189,13 @@ qemuDomainPinVcpuFlags(virDomainPtr dom,
     if (virDomainObjGetDefs(vm, flags, &def, &persistentDef) < 0)
         goto endjob;
 
+    if ((def && def->virtType == VIR_DOMAIN_VIRT_QEMU) ||
+        (persistentDef && persistentDef->virtType == VIR_DOMAIN_VIRT_QEMU)) {
+        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
+                       _("Virt type 'qemu' does not support vCPU pinning"));
+        goto endjob;
+    }
+
     if (persistentDef &&
         !(vcpuinfo = virDomainDefGetVcpu(persistentDef, vcpu))) {
         virReportError(VIR_ERR_INVALID_ARG,