From: Ian Jackson Date: Mon, 28 Nov 2011 17:16:52 +0000 (+0000) Subject: qemu-dm: open char devices "file:..." with O_APPEND X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=89daacab7035d408f32f2cb1acf68c96d6cbefed;p=people%2Fliuw%2Flibxenctrl-split%2Fqemu-xen-traditional.git qemu-dm: open char devices "file:..." with O_APPEND The "file:..." character open method is used by serial and parallel ports, to divert the output to a file (and these devices never produce any input). This is like a logfile, and so should be opened for append. In qemu-xen-unstable, this is used only for the qemu stderr by libxl. Signed-off-by: Ian Jackson Acked-by: Ian Campbell --- diff --git a/qemu-char.c b/qemu-char.c index 35e428d1..324ed16e 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -588,7 +588,7 @@ static CharDriverState *qemu_chr_open_file_out(const char *file_out) { int fd_out; - TFR(fd_out = open(file_out, O_WRONLY | O_TRUNC | O_CREAT | O_BINARY, 0666)); + TFR(fd_out = open(file_out, O_WRONLY | O_TRUNC | O_CREAT | O_BINARY | O_APPEND, 0666)); if (fd_out < 0) return NULL; return qemu_chr_open_fd(-1, fd_out);