From: Stefan Weil <weil@mail.berlios.de>
Date: Sun, 3 Apr 2011 16:21:24 +0000 (+0200)
Subject: spapr_vscsi: Set uninitialized variable
X-Git-Tag: v0.15.0-rc0~533
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=8804f57b531e4887ad9521c9abb9e0bbbcb1dd4e;p=qemu-xen-4.2-testing.git

spapr_vscsi: Set uninitialized variable

cppcheck reports this error:

hw/spapr_vscsi.c:274: error: Uninitialized variable: rc

If llen == 0, rc was indeed used without being initialized.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
---

diff --git a/hw/spapr_vscsi.c b/hw/spapr_vscsi.c
index e142dae62..992833450 100644
--- a/hw/spapr_vscsi.c
+++ b/hw/spapr_vscsi.c
@@ -255,7 +255,7 @@ static int vscsi_srp_direct_data(VSCSIState *s, vscsi_req *req,
 {
     struct srp_direct_buf *md = req->cur_desc;
     uint32_t llen;
-    int rc;
+    int rc = 0;
 
     dprintf("VSCSI: direct segment 0x%x bytes, va=0x%llx desc len=0x%x\n",
             len, (unsigned long long)md->va, md->len);