From: John Thomson <git@johnthomson.fastmail.com.au>
Date: Wed, 14 Mar 2018 08:21:24 +0000 (+1000)
Subject: tools: xenalyze.c fix format-truncation
X-Git-Tag: 4.11.0-rc1~235
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=87554421b9ffcebe0a89ba9a927bccc0c7bed7f3;p=people%2Fandrewcoop%2Fxen.git

tools: xenalyze.c fix format-truncation

With gcc optimization enabled by:
tools: detect appropriate debug optimization level
b43501451733193b265de30fd79a764363a2a473

-Wformat-truncation throws warnings

gcc version 7.3.0

xenalyze.c: In function 'find_symbol':
xenalyze.c:382:36: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
     snprintf(name, 128, "(%s +%llx)",
                                    ^
xenalyze.c:382:5: note: 'snprintf' output between 6 and 144 bytes into a destination of size 128
     snprintf(name, 128, "(%s +%llx)",
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              lastname, offset);
              ~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
---

diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index 5768b54f86..5ed0a12327 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -358,7 +358,7 @@ char * find_symbol(unsigned long long addr) {
     int i;
     char * lastname="ZERO";
     unsigned long long offset=addr;
-    static char name[128];
+    static char name[144];
 
     if(!p) {
         name[0]=0;
@@ -379,7 +379,7 @@ char * find_symbol(unsigned long long addr) {
         p=p->next;
     }
  finish:
-    snprintf(name, 128, "(%s +%llx)",
+    snprintf(name, 144, "(%s +%llx)",
              lastname, offset);
     return name;
 }