From: Osier Yang <jyang@redhat.com>
Date: Mon, 6 Dec 2010 09:41:10 +0000 (+0800)
Subject: util: Fix bug which will cause libvirtd crash
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=85ccf42cd0a8c956230312d6f69dc56666b99871;p=libvirt.git

util: Fix bug which will cause libvirtd crash

"virCommandRun": if "cmd->outbuf" or "cmd->errbuf" is NULL,
libvirtd will be crashed when trying to start a qemu domain
(which invokes "virCommandRun"), it caused by we try to use
"*cmd->outbuf" and "*cmd->errbuf" regardless of cmd->outbuf
or cmd->errbuf is NULL.

* src/util/command.c (virCommandRun)
---

diff --git a/src/util/command.c b/src/util/command.c
index aa43f76019..38d462b19d 100644
--- a/src/util/command.c
+++ b/src/util/command.c
@@ -931,8 +931,8 @@ virCommandRun(virCommandPtr cmd, int *exitstatus)
         ret = -1;
 
     VIR_DEBUG("Result stdout: '%s' stderr: '%s'",
-              NULLSTR(*cmd->outbuf),
-              NULLSTR(*cmd->errbuf));
+              cmd->outbuf ? NULLSTR(*cmd->outbuf) : "(null)",
+              cmd->errbuf ? NULLSTR(*cmd->errbuf) : "(null)");
 
     /* Reset any capturing, in case caller runs
      * this identical command again */