From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 3 Aug 2016 06:32:44 +0000 (+0200)
Subject: virqemu: Reflect return type of virJSONValueArraySize()
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=84b476e2bd20305d88840443c91ce2f5c01dd123;p=libvirt.git

virqemu: Reflect return type of virJSONValueArraySize()

The virJSONValueArraySize() function return ssize_t (with
possibly returning -1 if the passed json is not an array).
Storing the return value into size_t is possibly dangerous then.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/util/virqemu.c b/src/util/virqemu.c
index a1ba562ad2..0b516fc71b 100644
--- a/src/util/virqemu.c
+++ b/src/util/virqemu.c
@@ -85,7 +85,7 @@ virQEMUBuildCommandLineJSONArrayNumbered(const char *key,
                                          virBufferPtr buf)
 {
     const virJSONValue *member;
-    size_t nelems = virJSONValueArraySize(array);
+    ssize_t nelems = virJSONValueArraySize(array);
     char *prefix = NULL;
     size_t i;
     int ret = 0;