From: Matthias Goergens Date: Thu, 17 Jun 2010 21:16:18 +0000 (+0100) Subject: camldm/camldm_stubs.c: Tests have confirmed that camldm_ls does not leak memory. X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=82d6b886982236b08c9842083b63e2ccc57164ec;p=xcp%2Fxen-api-libs.git camldm/camldm_stubs.c: Tests have confirmed that camldm_ls does not leak memory. A comment in the file reflects this finding. Signed-off-by: Matthias Goergens --- diff --git a/camldm/camldm_stubs.c b/camldm/camldm_stubs.c index ae05672..929cea6 100644 --- a/camldm/camldm_stubs.c +++ b/camldm/camldm_stubs.c @@ -238,9 +238,13 @@ void camldm_mknod(value path, value mode, value major, value minor) CAMLreturn0; } -// may leak memory. who knows? (Does the c function I copied this -// from (dmsetup.c) care about memory? dmsetup exits shortly after executing -// it. +/* + May leak memory. who knows? (Does the c function (_process_all) + where I copied this from (dmsetup.c) care about memory? dmsetup + exits shortly after executing it. After testing: It does not seem + to leak. Probably "dm_task_destroy(dmt);" is doing some cleaning + up. +*/ #define none Val_int(0) #define Tag_some Val_int(0) value camldm_ls()