From: Michal Privoznik Date: Tue, 22 Oct 2019 11:10:20 +0000 (+0200) Subject: virpcimock: Make @fakerootdir static X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=816bd3e8ac40d523e64383dc9c0d9238284d61c7;p=libvirt.git virpcimock: Make @fakerootdir static Since we are not passing the @fakerootdir variable to any inline function anymore, we can make the variable static. Signed-off-by: Michal Privoznik Reviewed-by: Daniel Henrique Barboza --- diff --git a/tests/virpcimock.c b/tests/virpcimock.c index 0d502db68c..7e4554a1dc 100644 --- a/tests/virpcimock.c +++ b/tests/virpcimock.c @@ -39,11 +39,7 @@ static int (*real_close)(int fd); static DIR * (*real_opendir)(const char *name); static char *(*real_virFileCanonicalizePath)(const char *path); -/* Don't make static, since it causes problems with clang - * when passed as an arg to virAsprintf() - * vircgroupmock.c:462:22: error: static variable 'fakesysfsdir' is used in an inline function with external linkage [-Werror,-Wstatic-in-inline] - */ -char *fakerootdir; +static char *fakerootdir; /* To add a new mocked prefix in virpcimock: * - add the prefix here as a define to make it easier to track what we