From: Akihiko Odaki Date: Wed, 5 Apr 2023 07:00:30 +0000 (+0900) Subject: configure: Avoid -Werror=maybe-uninitialized X-Git-Tag: pull-xen-20230607~108^2~18 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=8041e9e314819de9f54f3e267a0479e329561b96;p=people%2Faperard%2Fqemu-dm.git configure: Avoid -Werror=maybe-uninitialized The configure script used to compile some code which dereferences memory with ubsan to verify the compiler can link with ubsan library which detects dereferencing of uninitialized memory. However, as the dereferenced memory was allocated in the same code, GCC can statically detect the unitialized memory dereference and emit maybe-uninitialized warning. If -Werror is set, this becomes an error, and the configure script incorrectly thinks the error indicates the compiler cannot use ubsan. Fix this error by replacing the code with another function which adds 1 to a signed integer argument. This brings in ubsan to detect if it causes signed integer overflow. As the value of the argument cannot be statically determined, the new function is also immune to compiler warnings. Signed-off-by: Akihiko Odaki Message-Id: <20230405070030.23148-1-akihiko.odaki@daynix.com> Signed-off-by: Paolo Bonzini --- diff --git a/configure b/configure index 6ed66ec6ab..22b8553b8d 100755 --- a/configure +++ b/configure @@ -1749,13 +1749,9 @@ if test "$sanitizers" = "yes" ; then # detect the static linking issue of ubsan, see also: # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84285 cat > $TMPC << EOF -#include -int main(void) { - void *tmp = malloc(10); - if (tmp != NULL) { - return *(int *)(tmp + 2); - } - return 1; +int main(int argc, char **argv) +{ + return argc + 1; } EOF if compile_prog "$CPU_CFLAGS -Werror -fsanitize=undefined" ""; then