From: Matthew Daley <mattjd@gmail.com>
Date: Wed, 18 Sep 2013 03:37:57 +0000 (+1200)
Subject: mini-os: fix nodename generation in init_netfront
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=7fb40ef26d82d2625fca89b2717cdb947f4a94aa;p=people%2Fliuw%2Flibxenctrl-split%2Fmini-os.git

mini-os: fix nodename generation in init_netfront

Using strlen here makes no sense.

Coverity-ID: 1056053
Signed-off-by: Matthew Daley <mattjd@gmail.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---

diff --git a/netfront.c b/netfront.c
index 4e087a5..a999985 100644
--- a/netfront.c
+++ b/netfront.c
@@ -309,8 +309,10 @@ struct netfront_dev *init_netfront(char *_nodename, void (*thenetif_rx)(unsigned
 
     if (!_nodename)
         snprintf(nodename, sizeof(nodename), "device/vif/%d", netfrontends);
-    else
-        strncpy(nodename, _nodename, strlen(nodename));
+    else {
+        strncpy(nodename, _nodename, sizeof(nodename) - 1);
+        nodename[sizeof(nodename) - 1] = 0;
+    }
     netfrontends++;
 
     if (!thenetif_rx)