From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 20 May 2021 10:17:09 +0000 (+0200)
Subject: conf: node_device: Fix build with clang
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=7eb281f91c8753852d0b1c5a01502736e5b75f00;p=libvirt.git

conf: node_device: Fix build with clang

Clang complains:

  ../libvirt/src/conf/node_device_conf.c:1945:74: error: result of comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-enum-zero-compare]
        if ((mdev->start = virNodeDevMdevStartTypeFromString(starttype)) < 0) {

Fixes: 42a55854993
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 4e2b37c612..5598d420fe 100644
--- a/src/conf/node_device_conf.c
+++ b/src/conf/node_device_conf.c
@@ -1942,11 +1942,14 @@ virNodeDevCapMdevParseXML(xmlXPathContextPtr ctxt,
     }
 
     if ((starttype = virXPathString("string(./start[1]/@type)", ctxt))) {
-        if ((mdev->start = virNodeDevMdevStartTypeFromString(starttype)) < 0) {
+        int tmp;
+        if ((tmp = virNodeDevMdevStartTypeFromString(starttype)) < 0) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("unknown mdev start type '%s' for '%s'"), starttype, def->name);
             return -1;
         }
+
+        mdev->start = tmp;
     } else {
         mdev->start = VIR_NODE_DEV_MDEV_START_MANUAL;
     }