From: Federico Serafini <federico.serafini@bugseng.com>
Date: Tue, 8 Oct 2024 12:37:16 +0000 (+0200)
Subject: xen/pci: address a violation of MISRA C Rule 16.3
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=7d83c392c7bfecdfcb7a91166cc75edd79e49a05;p=people%2Faperard%2Fxen-unstable.git

xen/pci: address a violation of MISRA C Rule 16.3

Refactor the code to avoid an implicit fallthrough and address
a violation of MISRA C:2012 Rule 16.3: "An unconditional `break'
statement shall terminate every switch-clause".

No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 5a446d3dce..74d3895e1e 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -170,8 +170,11 @@ static int __init cf_check parse_phantom_dev(const char *str)
     {
     case 1: case 2: case 4:
         if ( *s )
-    default:
             return -EINVAL;
+        break;
+
+    default:
+        return -EINVAL;
     }
 
     phantom_devs[nr_phantom_devs++] = phantom;