From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
Date: Tue, 12 Apr 2011 12:28:51 +0000 (+0100)
Subject: remus: fix incorrect error handling for switch_qemu_logdirty in checkpoint code
X-Git-Tag: 4.2.0-rc1~2381
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=7d75f6881e5d438d5eb1d2abda78c64b43ab8544;p=xen.git

remus: fix incorrect error handling for switch_qemu_logdirty in checkpoint code

c/s 22275: "tools: cleanup domain save switch_qemu_logdirty callback"
introduced a whole bunch of error code fixups. In the process, it also
ended up treating the success return code (0) from
switch_qemu_logdirty as an error and vice versa.

Signed-off-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>
---

diff --git a/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c b/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c
index f4d3e7fd1a..e96dc8f067 100644
--- a/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c
+++ b/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c
@@ -185,7 +185,7 @@ int checkpoint_start(checkpoint_state* s, int fd,
     hvm = s->domtype > dt_pv;
     if (hvm) {
        flags |= XCFLAGS_HVM;
-       if (!switch_qemu_logdirty(s, 1))
+       if (switch_qemu_logdirty(s, 1))
            return -1;
     }