From: John Ferlan <jferlan@redhat.com>
Date: Mon, 18 Jul 2016 18:30:59 +0000 (-0400)
Subject: conf: Need to check for glisten before accessing
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=7ca6cd7def2fbbd4308842cf4222fde7891d2987;p=libvirt.git

conf: Need to check for glisten before accessing

When formatting the graphics data for TYPE_SPICE, check if the glisten
is NULL before blindly referencing

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 15fd8cab0d..6dfcf81e9e 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -22182,6 +22182,12 @@ virDomainGraphicsDefFormat(virBufferPtr buf,
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_SPICE:
+        if (!glisten) {
+            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                           _("missing listen element for spice graphics"));
+            return -1;
+        }
+
         switch (glisten->type) {
         case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS:
         case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: