From: aliguori Date: Fri, 12 Sep 2008 17:54:13 +0000 (+0000) Subject: Let snapshot work with protocols X-Git-Tag: stefano.display-merge-start~589 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=7c96d46ec245d73fd76726588409f9abe4bd5dc1;p=qemu-xen-4.4-testing.git Let snapshot work with protocols realpath will horribly mangle a protocol so avoid calling it if the backing file is a protocol. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5200 c046a42c-6fe2-441c-8c8c-71466251a162 --- diff --git a/block.c b/block.c index e81df0a79..52c8f37a2 100644 --- a/block.c +++ b/block.c @@ -338,6 +338,7 @@ int bdrv_open2(BlockDriverState *bs, const char *filename, int flags, if (flags & BDRV_O_SNAPSHOT) { BlockDriverState *bs1; int64_t total_size; + int is_protocol = 0; /* if snapshot, we create a temporary backing file and open it instead of opening 'filename' directly */ @@ -352,10 +353,21 @@ int bdrv_open2(BlockDriverState *bs, const char *filename, int flags, return -1; } total_size = bdrv_getlength(bs1) >> SECTOR_BITS; + + if (bs1->drv && bs1->drv->protocol_name) + is_protocol = 1; + bdrv_delete(bs1); get_tmp_filename(tmp_filename, sizeof(tmp_filename)); - realpath(filename, backing_filename); + + /* Real path is meaningless for protocols */ + if (is_protocol) + snprintf(backing_filename, sizeof(backing_filename), + "%s", filename); + else + realpath(filename, backing_filename); + if (bdrv_create(&bdrv_qcow2, tmp_filename, total_size, backing_filename, 0) < 0) { return -1;