From: Martin Kletzander <mkletzan@redhat.com>
Date: Wed, 16 Aug 2017 09:09:47 +0000 (+0200)
Subject: util: Umark virBufferCheckErrorInternal as ATTRIBUTE_RETURN_CHECK
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=7addfa195b9075d62b6449b429c8d009386c2ba9;p=libvirt.git

util: Umark virBufferCheckErrorInternal as ATTRIBUTE_RETURN_CHECK

The function is useful even without using the return value.  And if
needed, the return value can be obtained by other calls as well.  The
potential for clean-up can be seen in the following patch.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/util/virbuffer.h b/src/util/virbuffer.h
index 6ad9c3ec54..3211c07b08 100644
--- a/src/util/virbuffer.h
+++ b/src/util/virbuffer.h
@@ -58,7 +58,7 @@ int virBufferCheckErrorInternal(const virBuffer *buf,
                                 const char *filename,
                                 const char *funcname,
                                 size_t linenr)
-    ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(1);
+    ATTRIBUTE_NONNULL(1);
 /**
  * virBufferCheckError
  *