From: Fam Zheng Date: Thu, 11 Sep 2014 05:41:22 +0000 (+0800) Subject: quorum: Convert quorum_aiocb_info.cancel to .cancel_async X-Git-Tag: qemu-xen-4.6.0-rc1~189^2~40 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=7940e5056bfdb5d2861774e294d5459952cd0aee;p=qemu-upstream-unstable.git quorum: Convert quorum_aiocb_info.cancel to .cancel_async Before, we cancel all the child requests with bdrv_aio_cancel, then free the acb.. Now we just kick off asynchronous cancellation of child requests and return, we know quorum_aio_cb will be called later, so in the end quorum_aio_finalize will take care of calling the caller's cb. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- diff --git a/block/quorum.c b/block/quorum.c index 41c424954..f343c04c5 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -139,17 +139,14 @@ static void quorum_aio_cancel(BlockDriverAIOCB *blockacb) /* cancel all callbacks */ for (i = 0; i < s->num_children; i++) { if (acb->qcrs[i].aiocb) { - bdrv_aio_cancel(acb->qcrs[i].aiocb); + bdrv_aio_cancel_async(acb->qcrs[i].aiocb); } } - - g_free(acb->qcrs); - qemu_aio_release(acb); } static AIOCBInfo quorum_aiocb_info = { .aiocb_size = sizeof(QuorumAIOCB), - .cancel = quorum_aio_cancel, + .cancel_async = quorum_aio_cancel, }; static void quorum_aio_finalize(QuorumAIOCB *acb)