From: Pavel Hrdina <phrdina@redhat.com>
Date: Mon, 13 Jan 2014 13:48:40 +0000 (+0100)
Subject: Fix possible memory leak in phyp_driver.c
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=788e6cb25bbcdbef6fe945ac1533a40faf8f4293;p=libvirt.git

Fix possible memory leak in phyp_driver.c

There could be a memory leak caused by "managed_system" string, if any
error occurs before "managed_system" is assigned into
"phyp_driver->managed_system". The "managed_system" string wouldn't be
freed at all. The better way is to free the "managed_system" instead
of the one assigned in the "phyp_driver".

This has been found by coverity.

Pointed out by John, that the "phyp_driver->xmlopt" needs to be
unreferenced as well.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index 32165ed201..3ff3006f98 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -1153,9 +1153,11 @@ phypConnectOpen(virConnectPtr conn,
     return VIR_DRV_OPEN_SUCCESS;
 
 failure:
+    VIR_FREE(managed_system);
+
     if (phyp_driver != NULL) {
         virObjectUnref(phyp_driver->caps);
-        VIR_FREE(phyp_driver->managed_system);
+        virObjectUnref(phyp_driver->xmlopt);
         VIR_FREE(phyp_driver);
     }