From: Ján Tomko <jtomko@redhat.com>
Date: Fri, 18 Oct 2019 15:24:29 +0000 (+0200)
Subject: virsh: use g_strdup in virshDomainGetEditMetadata
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=76b4cd88f5665a809dfb9ad5b92660294f9be434;p=libvirt.git

virsh: use g_strdup in virshDomainGetEditMetadata

Prefer GLib's g_strdup to vshStrdup.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 3ba8451470..715ad51ef5 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -8523,7 +8523,7 @@ static const vshCmdOptDef opts_metadata[] = {
 
 /* helper to add new metadata using the --edit option */
 static char *
-virshDomainGetEditMetadata(vshControl *ctl,
+virshDomainGetEditMetadata(vshControl *ctl G_GNUC_UNUSED,
                            virDomainPtr dom,
                            const char *uri,
                            unsigned int flags)
@@ -8533,7 +8533,7 @@ virshDomainGetEditMetadata(vshControl *ctl,
     if (!(ret = virDomainGetMetadata(dom, VIR_DOMAIN_METADATA_ELEMENT,
                                      uri, flags))) {
         vshResetLibvirtError();
-        ret = vshStrdup(ctl, "\n");
+        ret = g_strdup("\n");
     }
 
     return ret;