From: Cole Robinson <crobinso@redhat.com>
Date: Mon, 25 Apr 2016 18:16:07 +0000 (-0400)
Subject: daemon: stream: set stream->closed on removal
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=75e19990425fcc996a979c676fee899ae2e6e4c9;p=libvirt.git

daemon: stream: set stream->closed on removal

These are the only places where we don't set stream->closed when
aborting the stream. This leads to spurious errors when the client
hangs up unexpectedly:

error : virFDStreamUpdateCallback:127 : internal error: stream is not open
---

diff --git a/daemon/stream.c b/daemon/stream.c
index 8a9726059f..fcec3d0608 100644
--- a/daemon/stream.c
+++ b/daemon/stream.c
@@ -463,6 +463,7 @@ daemonRemoveClientStream(virNetServerClientPtr client,
     }
 
     if (!stream->closed) {
+        stream->closed = true;
         virStreamEventRemoveCallback(stream->st);
         virStreamAbort(stream->st);
     }
@@ -493,6 +494,7 @@ daemonRemoveAllClientStreams(daemonClientStream *stream)
         tmp = stream->next;
 
         if (!stream->closed) {
+            stream->closed = true;
             virStreamEventRemoveCallback(stream->st);
             virStreamAbort(stream->st);
         }