From: Luyao Huang <lhuang@redhat.com>
Date: Fri, 22 May 2015 09:26:29 +0000 (+0800)
Subject: conf: Avoid formatting empty redirfilter element
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=733950c21cc4566f4898fe0d331bc2790930e7ce;p=libvirt.git

conf: Avoid formatting empty redirfilter element

If the redirfilter has no usbdev sub-elements, then do not format anything
rather than formatting an empty pair of elements:

    <redirfilter>
    </redirfilter>

Signed-off-by: Luyao Huang <lhuang@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0a3a6245ae..6e5742509c 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -20626,6 +20626,10 @@ virDomainRedirFilterDefFormat(virBufferPtr buf,
 {
     size_t i;
 
+    /* no need format an empty redirfilter */
+    if (filter->nusbdevs == 0)
+        return 0;
+
     virBufferAddLit(buf, "<redirfilter>\n");
     virBufferAdjustIndent(buf, 2);
     for (i = 0; i < filter->nusbdevs; i++) {