From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 20 Dec 2018 03:16:07 +0000 (+0800)
Subject: scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param
X-Git-Tag: v5.4.17~4340^2~14
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=72b4a0465f995175a2e22cf4a636bf781f1f28a7;p=arm%2Flinux.git

scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param

The return code should be check while qla4xxx_copy_from_fwddb_param fails.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 949e186cc5d7..1bc4db6e6d16 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -7232,6 +7232,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct scsi_qla_host *ha,
 
 	rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
 					   fw_ddb_entry);
+	if (rc)
+		goto free_sess;
 
 	ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
 		   __func__, fnode_sess->dev.kobj.name);