From: Martin Kletzander <mkletzan@redhat.com>
Date: Fri, 11 Mar 2016 13:21:56 +0000 (+0100)
Subject: qemu: Don't access uninitialized memory
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=71fa2eb26c18c53d9e498e5f75c6307003e72c8e;p=libvirt.git

qemu: Don't access uninitialized memory

In qemuConnectDomainXMLToNative() we set up the monitor, but we never
memset() it to zeros.  Thanks to the introduction of the logfile
parameter of chardevs (and the logfile member of the struct), we started
checking whether that's non-NULL and that exposed this old error.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 29c3bc8f8a..877ef20708 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -6950,7 +6950,7 @@ static char *qemuConnectDomainXMLToNative(virConnectPtr conn,
 {
     virQEMUDriverPtr driver = conn->privateData;
     virDomainDefPtr def = NULL;
-    virDomainChrSourceDef monConfig;
+    virDomainChrSourceDef monConfig = {0};
     virQEMUCapsPtr qemuCaps = NULL;
     bool monitor_json = false;
     virCommandPtr cmd = NULL;