From: Luyao Huang <lhuang@redhat.com>
Date: Thu, 26 Feb 2015 06:14:20 +0000 (+0800)
Subject: conf: error out on invalid host id
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=719cd2182bf06196b26204a8cf88d28001b1d79b;p=libvirt.git

conf: error out on invalid host id

https://bugzilla.redhat.com/show_bug.cgi?id=1196503

We already check whether the host id is valid or not, add a jump
to forbid invalid host id.

Signed-off-by: Luyao Huang <lhuang@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 3d8bf054ff..52fcf3d2aa 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -717,6 +717,7 @@ virNetworkDHCPHostDefParseXML(const char *networkName,
             virReportError(VIR_ERR_XML_ERROR,
                            _("Invalid character '%c' in id '%s' of network '%s'"),
                            *cp, id, networkName);
+            goto cleanup;
         }
     }