From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 9 Aug 2021 16:14:24 +0000 (+0100)
Subject: ui/sdl2: Check return value from g_setenv()
X-Git-Tag: qemu-xen-4.16.0-rc4~12^2
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=6ff5b5d6d521001135d1bd5c609e8834099f01d8;p=qemu-xen.git

ui/sdl2: Check return value from g_setenv()

Setting environment variables can fail; check the return value
from g_setenv() and bail out if we couldn't set SDL_VIDEODRIVER.

Fixes: Coverity 1458798
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20210809161424.32355-1-peter.maydell@linaro.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---

diff --git a/ui/sdl2.c b/ui/sdl2.c
index 36d9010cb6..17c0ec30eb 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -817,7 +817,10 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
      * This is a bit hackish but saves us from bigger problem.
      * Maybe it's a good idea to fix this in SDL instead.
      */
-    g_setenv("SDL_VIDEODRIVER", "x11", 0);
+    if (!g_setenv("SDL_VIDEODRIVER", "x11", 0)) {
+        fprintf(stderr, "Could not set SDL_VIDEODRIVER environment variable\n");
+        exit(1);
+    }
 #endif
 
     if (SDL_Init(SDL_INIT_VIDEO)) {