From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Date: Tue, 10 Sep 2024 22:15:37 +0000 (-0700)
Subject: system: replace assert(0) with g_assert_not_reached()
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=6e7d8c5f3d52283e3621bf84ba59fd0b54e79fcb;p=qemu-xen.git

system: replace assert(0) with g_assert_not_reached()

Use of assert(false) can trip spurious control flow warnings from
some versions of GCC (i.e. using -fsanitize=thread with gcc-12):

  error: control reaches end of non-void function [-Werror=return-type]
        default:
            assert(0);
      | }
      | ^

Solve that by unifying the code base on g_assert_not_reached() instead.

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240910221606.1817478-11-pierrick.bouvier@linaro.org>
[PMD: Add description suggested by Eric Blake]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---

diff --git a/system/rtc.c b/system/rtc.c
index dc44576686..216d2aee3a 100644
--- a/system/rtc.c
+++ b/system/rtc.c
@@ -62,7 +62,7 @@ static time_t qemu_ref_timedate(QEMUClockType clock)
         }
         break;
     default:
-        assert(0);
+        g_assert_not_reached();
     }
     return value;
 }