From: Martin Kletzander <mkletzan@redhat.com>
Date: Tue, 7 Apr 2015 15:18:01 +0000 (+0200)
Subject: closeCallback is already lockable, initialize it as such
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=6dfbaca7b7b2bf36e2ad2dbbb8f3d029810d3d60;p=people%2Fliuw%2Flibxenctrl-split%2Flibvirt.git

closeCallback is already lockable, initialize it as such

Luckily we are allocating structs as clean memory and
PTHREAD_MUTEX_INITIALIZER is "{ 0 }", so nothing happened, but it should
still be created as lockable object.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/datatypes.c b/src/datatypes.c
index 0f535b44e..dc024f839 100644
--- a/src/datatypes.c
+++ b/src/datatypes.c
@@ -1,7 +1,7 @@
 /*
  * datatypes.c: management of structs for public data types
  *
- * Copyright (C) 2006-2014 Red Hat, Inc.
+ * Copyright (C) 2006-2015 Red Hat, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -113,7 +113,7 @@ virGetConnect(void)
     if (!(ret = virObjectNew(virConnectClass)))
         return NULL;
 
-    if (!(ret->closeCallback = virObjectNew(virConnectCloseCallbackDataClass)))
+    if (!(ret->closeCallback = virObjectLockableNew(virConnectCloseCallbackDataClass)))
         goto error;
 
     if (virMutexInit(&ret->lock) < 0)