From: John Ferlan <jferlan@redhat.com>
Date: Mon, 2 Apr 2018 11:19:38 +0000 (-0400)
Subject: tests: Don't call virNetServerClientClose without valid client
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=6df5d7772330b20ea81f9f989afe3dc789b9ca31;p=libvirt.git

tests: Don't call virNetServerClientClose without valid client

If @client hasn't been opened, then don't call virNetServerClientClose
since that'll cause certain failure.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/tests/virnetserverclienttest.c b/tests/virnetserverclienttest.c
index 398b46928c..aa3f0bcf9b 100644
--- a/tests/virnetserverclienttest.c
+++ b/tests/virnetserverclienttest.c
@@ -152,7 +152,8 @@ static int testIdentity(const void *opaque ATTRIBUTE_UNUSED)
     ret = 0;
  cleanup:
     virObjectUnref(sock);
-    virNetServerClientClose(client);
+    if (!client)
+        virNetServerClientClose(client);
     virObjectUnref(client);
     virObjectUnref(ident);
     VIR_FORCE_CLOSE(sv[0]);