From: Peter Maydell Date: Tue, 9 Oct 2018 18:40:17 +0000 (+0100) Subject: linux-user/sparc/signal.c: Remove unnecessary comment X-Git-Tag: qemu-xen-4.13.0-rc1~617^2 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=6d5bb0b896f9954c98d85c8835a75bb3a041de41;p=qemu-xen.git linux-user/sparc/signal.c: Remove unnecessary comment Remove a comment suggesting that we need to call tb_flush() after writing the SPARC signal frame trampoline insns. This isn't necessary in QEMU, because (even if the guest architecture requires explicit icache maintenance) we ensure that memory writes result in invalidation of translated code from that memory. Signed-off-by: Peter Maydell Message-Id: <20181009184017.15675-1-peter.maydell@linaro.org> Signed-off-by: Laurent Vivier --- diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c index b4c60aa446..e44e99993c 100644 --- a/linux-user/sparc/signal.c +++ b/linux-user/sparc/signal.c @@ -258,10 +258,6 @@ void setup_frame(int sig, struct target_sigaction *ka, __put_user(val32, &sf->insns[1]); if (err) goto sigsegv; - - /* Flush instruction space. */ - // flush_sig_insns(current->mm, (unsigned long) &(sf->insns[0])); - // tb_flush(env); } unlock_user(sf, sf_addr, sizeof(struct target_signal_frame)); return;