From: John Ferlan <jferlan@redhat.com>
Date: Thu, 8 Oct 2015 17:35:01 +0000 (-0400)
Subject: storage: Remove duplicitous refreshVol in Sheepdog buildVol
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=6ab98a68b7c55e64568b690979ffd29655a16760;p=people%2Fliuw%2Flibxenctrl-split%2Flibvirt.git

storage: Remove duplicitous refreshVol in Sheepdog buildVol

As of commit id '155ca616' a 'refreshVol' is called after a buildVol
succeeds in storageVolCreateXML, thus a volStorageBackendSheepdogRefreshVolInfo
call in virStorageBackendSheepdogBuildVol is no longer necessary.

Additionally, the 'conn' parameter becomes unused.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c
index 69ba78361..120081391 100644
--- a/src/storage/storage_backend_sheepdog.c
+++ b/src/storage/storage_backend_sheepdog.c
@@ -257,7 +257,7 @@ virStorageBackendSheepdogCreateVol(virConnectPtr conn ATTRIBUTE_UNUSED,
 
 
 static int
-virStorageBackendSheepdogBuildVol(virConnectPtr conn,
+virStorageBackendSheepdogBuildVol(virConnectPtr conn ATTRIBUTE_UNUSED,
                                   virStoragePoolObjPtr pool,
                                   virStorageVolDefPtr vol,
                                   unsigned int flags)
@@ -279,9 +279,6 @@ virStorageBackendSheepdogBuildVol(virConnectPtr conn,
     if (virCommandRun(cmd, NULL) < 0)
         goto cleanup;
 
-    if (virStorageBackendSheepdogRefreshVol(conn, pool, vol) < 0)
-        goto cleanup;
-
     ret = 0;
  cleanup:
     virCommandFree(cmd);