From: Paul Durrant <paul.durrant@citrix.com>
Date: Fri, 22 Jan 2016 17:11:13 +0000 (+0000)
Subject: Avoid evaluating assertion expressions in free builds
X-Git-Tag: 8.2.0-rc1~32
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=6a7a7da5fad280c5fdd0ea47d5d545d1e65d9d84;p=people%2Fpauldu%2Fxeniface.git

Avoid evaluating assertion expressions in free builds

The evaluations are pointless and the warnings generated by not evaluating
can be squashed with a couple of #pragmas.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---

diff --git a/src/xeniface/assert.h b/src/xeniface/assert.h
index 83b215f..cac74c2 100644
--- a/src/xeniface/assert.h
+++ b/src/xeniface/assert.h
@@ -126,18 +126,12 @@ __Bug(
 
 #else   // DBG
 
-static FORCEINLINE VOID
-_IgnoreAssertion(
-    IN  BOOLEAN Value
-    )
-{
-    UNREFERENCED_PARAMETER(Value);
-}
+#pragma warning(disable:4100)
+#pragma warning(disable:4189)
 
-#define ASSERT(_EXP)                        \
-        do {                                \
-            _IgnoreAssertion(_EXP);         \
-            __analysis_assume(_EXP);        \
+#define ASSERT(_EXP)                    \
+        do {                            \
+            __analysis_assume(_EXP);    \
         } while (FALSE)
 
 #define ASSERT3U(_X, _OP, _Y)           \