From: John Thomson Date: Tue, 15 May 2018 01:48:43 +0000 (+1000) Subject: tools/ocaml/libs/xc fix gcc-8 format-truncation warning X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=6a1c431890599c701117bf9822898f60a18444a3;p=xen.git tools/ocaml/libs/xc fix gcc-8 format-truncation warning CC xenctrl_stubs.o xenctrl_stubs.c: In function 'failwith_xc': xenctrl_stubs.c:65:17: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=] "%d: %s: %s", error->code, ^ xenctrl_stubs.c:64:4: note: 'snprintf' output 6 or more bytes (assuming 1029) into a destination of size 1028 snprintf(error_str, sizeof(error_str), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ "%d: %s: %s", error->code, ~~~~~~~~~~~~~~~~~~~~~~~~~~ xc_error_code_to_desc(error->code), ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error->message); ~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[8]: *** [/build/xen-git/src/xen/tools/ocaml/libs/xc/../../Makefile.rules:37: xenctrl_stubs.o] Error 1 m Signed-off-by: John Thomson Acked-by: Christian Lindig Release-acked-by: Juergen Gross (cherry picked from commit 2adc90908fbb1e614c477e29f2d45eda94570795) --- diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index f1b28db53a..beefe6e8ad 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -54,7 +54,7 @@ static void Noreturn failwith_xc(xc_interface *xch) { - char error_str[1028]; + char error_str[XC_MAX_ERROR_MSG_LEN + 6]; if (xch) { const xc_error *error = xc_get_last_error(xch); if (error->code == XC_ERROR_NONE)