From: Alex Williamson Date: Wed, 21 Jul 2010 14:35:31 +0000 (-0600) Subject: savevm: Fix memory leak of compat struct X-Git-Tag: xen-15-06-02~7173 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=69e58af92cf90a1a0551c73880928afa6753fa5f;p=people%2Fsstabellini%2Fqemu-dm.git%2F.git savevm: Fix memory leak of compat struct Forgot to check for and free these. Found-by: Zachary Amsden Signed-off-by: Alex Williamson Signed-off-by: Aurelien Jarno --- diff --git a/savevm.c b/savevm.c index 7a1de3c532..4c0e5d3b10 100644 --- a/savevm.c +++ b/savevm.c @@ -1139,6 +1139,9 @@ void unregister_savevm(DeviceState *dev, const char *idstr, void *opaque) QTAILQ_FOREACH_SAFE(se, &savevm_handlers, entry, new_se) { if (strcmp(se->idstr, id) == 0 && se->opaque == opaque) { QTAILQ_REMOVE(&savevm_handlers, se, entry); + if (se->compat) { + qemu_free(se->compat); + } qemu_free(se); } } @@ -1206,6 +1209,9 @@ void vmstate_unregister(DeviceState *dev, const VMStateDescription *vmsd, QTAILQ_FOREACH_SAFE(se, &savevm_handlers, entry, new_se) { if (se->vmsd == vmsd && se->opaque == opaque) { QTAILQ_REMOVE(&savevm_handlers, se, entry); + if (se->compat) { + qemu_free(se->compat); + } qemu_free(se); } }