From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 8 Jun 2016 09:04:04 +0000 (+0200)
Subject: virschematest: Access the right directory containing XMLs
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=6895068d6d869c54df8efc8cbc69b14c8a58831d;p=libvirt.git

virschematest: Access the right directory containing XMLs

So the story goes like this. The testSchemaDirs() function is
called with: a) the schema file, b) list of the directories that
contains XMLs documents that should be checked against the schema
file from a). However, the directories in the list are really
just their names and it's up to testSchemaDirs to construct the
absolute path and call testSchemaDir() which then does the actual
validation. The absolute path is constructed, but never actually
used (maybe due to a typo). Thus a VPATH build is broken.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/tests/virschematest.c b/tests/virschematest.c
index f4d41bd13f..c173037900 100644
--- a/tests/virschematest.c
+++ b/tests/virschematest.c
@@ -140,7 +140,7 @@ testSchemaDirs(const char *schema, ...)
             ret = -1;
             goto cleanup;
         }
-        if (testSchemaDir(schema, validator, dir) < 0)
+        if (testSchemaDir(schema, validator, dir_path) < 0)
             ret = -1;
         VIR_FREE(dir_path);
     }