From: Michal Privoznik Date: Tue, 6 Sep 2022 11:37:23 +0000 (+0200) Subject: qemu_namespace: Tolerate missing ACLs when creating a path in namespace X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=687374959e160dc566bd4b6d43c7bf1beb470c59;p=libvirt.git qemu_namespace: Tolerate missing ACLs when creating a path in namespace When creating a path in a domain's mount namespace we try to set ACLs on it, so that it's a verbatim copy of the path in parent's namespace. The ACLs are queried upfront (by qemuNamespaceMknodItemInit()) but this is fault tolerant so the pointer to ACLs might be NULL (meaning no ACLs were queried, for instance because the underlying filesystem does not support them). But then we take this NULL and pass it to virFileSetACLs() which immediately returns an error because NULL is invalid value. Mimic what we do with SELinux label - only set ACLs if they are non-NULL which includes symlinks. Signed-off-by: Michal Privoznik Reviewed-by: Martin Kletzander --- diff --git a/src/qemu/qemu_namespace.c b/src/qemu/qemu_namespace.c index 98cd794666..71e3366ca5 100644 --- a/src/qemu/qemu_namespace.c +++ b/src/qemu/qemu_namespace.c @@ -1040,8 +1040,7 @@ qemuNamespaceMknodOne(qemuNamespaceMknodItem *data) goto cleanup; } - /* Symlinks don't have ACLs. */ - if (!isLink && + if (data->acl && virFileSetACLs(data->file, data->acl) < 0 && errno != ENOTSUP) { virReportSystemError(errno,