From: Daniel P. Berrange <berrange@redhat.com>
Date: Tue, 17 Aug 2010 14:23:27 +0000 (-0400)
Subject: Add explicit warning messages when failing to serialize to XDR
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=677c834ca7ddb267657c2b951d9770e0854946f9;p=libvirt.git

Add explicit warning messages when failing to serialize to XDR

When libvirtd fails to serialize a message to XDR the client
connection is terminated immediately. To enable this to be
diagnosed, log the message which caused the problem on the
server

* daemon/dispatch.c: Log XDR serialization failures
---

diff --git a/daemon/dispatch.c b/daemon/dispatch.c
index 302829836b..da810e2241 100644
--- a/daemon/dispatch.c
+++ b/daemon/dispatch.c
@@ -198,6 +198,8 @@ remoteSerializeError(struct qemud_client *client,
     return 0;
 
 xdr_error:
+    VIR_WARN("Failed to serialize remote error '%s' as XDR",
+             rerr->message ? *rerr->message : "<unknown>");
     xdr_destroy(&xdr);
     VIR_FREE(msg);
 fatal_error:
@@ -602,6 +604,8 @@ xdr_error:
     xdr_free (data->ret_filter, (char*)&ret);
     xdr_destroy (&xdr);
 fatal_error:
+    VIR_WARN("Failed to serialize reply for program '%d' proc '%d' as XDR",
+             msg->hdr.prog, msg->hdr.proc);
     return -1;
 }
 
@@ -685,5 +689,7 @@ xdr_error:
     xdr_destroy (&xdr);
 fatal_error:
     VIR_FREE(msg);
+    VIR_WARN("Failed to serialize stream data for proc %d as XDR",
+             stream->procedure);
     return -1;
 }