From: Martin Kletzander <mkletzan@redhat.com>
Date: Tue, 12 Mar 2013 15:34:31 +0000 (+0100)
Subject: Fix snapshot-create-as syntax in help output
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=66f1bbc35012b36d7af82dec9fa956b84b4ba8e9;p=libvirt.git

Fix snapshot-create-as syntax in help output

According to the man page, the memspec parameter should have the
'--memspec' option mandatory and this is as close as we can get to
that.  What this change does is explained below.

man virsh:

snapshot-create-as ... [[--live] [--memspec memspec]]

virsh help snapshot-create-as before this patch:

  SYNOPSIS
    snapshot-create-as ... [<memspec>] ...
...
  OPTIONS
    [--memspec] <string> ...

virsh help snapshot-create-as after this patch:

  SYNOPSIS
    snapshot-create-as ... [--memspec <string>] ...
...
  OPTIONS
    --memspec <string> ...
---

diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
index d994fd91b2..c2db99b52f 100644
--- a/tools/virsh-snapshot.c
+++ b/tools/virsh-snapshot.c
@@ -397,7 +397,7 @@ static const vshCmdOptDef opts_snapshot_create_as[] = {
      .help = N_("take a live snapshot")
     },
     {.name = "memspec",
-     .type = VSH_OT_DATA,
+     .type = VSH_OT_STRING,
      .flags = VSH_OFLAG_REQ_OPT,
      .help = N_("memory attributes: [file=]name[,snapshot=type]")
     },