From: Zheyu Ma Date: Wed, 20 Mar 2024 09:04:42 +0000 (+0100) Subject: libqos/virtio.c: Correct 'flags' reading in qvirtqueue_kick X-Git-Tag: qemu-xen-4.20.0~219^2~2 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=66e411885a23c96ff73742d06b793fec3ceaebb7;p=qemu-xen.git libqos/virtio.c: Correct 'flags' reading in qvirtqueue_kick In qvirtqueue_kick(), the 'flags' were previously being incorrectly read from vq->avail instead of the correct vq->used location. This update ensures 'flags' are read from the correct location as per the virtio standard. Signed-off-by: Zheyu Ma Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Message-ID: <20240320090442.267525-1-zheyuma97@gmail.com> Signed-off-by: Thomas Huth --- diff --git a/tests/qtest/libqos/virtio.c b/tests/qtest/libqos/virtio.c index 82a6e122bf..a21b6eee9c 100644 --- a/tests/qtest/libqos/virtio.c +++ b/tests/qtest/libqos/virtio.c @@ -394,7 +394,7 @@ void qvirtqueue_kick(QTestState *qts, QVirtioDevice *d, QVirtQueue *vq, qvirtio_writew(d, qts, vq->avail + 2, idx + 1); /* Must read after idx is updated */ - flags = qvirtio_readw(d, qts, vq->avail); + flags = qvirtio_readw(d, qts, vq->used); avail_event = qvirtio_readw(d, qts, vq->used + 4 + sizeof(struct vring_used_elem) * vq->size);