From: Eric Blake <eblake@redhat.com>
Date: Tue, 31 Jul 2012 14:05:14 +0000 (-0600)
Subject: qemu: fix use after free
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=665c8cdecc2d91a83f08a6ec95531b0de57c0e0a;p=libvirt.git

qemu: fix use after free

Detected by Coverity.

* src/qemu/qemu_hotplug.c (qemuDomainAttachHostDevice): Avoid
double free of usb on failure.
---

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index ba841e9269..ceffe22846 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1170,6 +1170,7 @@ int qemuDomainAttachHostDevice(struct qemud_driver *driver,
 
         if (usbDeviceListAdd(list, usb) < 0) {
             usbFreeDevice(usb);
+            usb = NULL:
             goto cleanup;
         }