From: Ján Tomko <jtomko@redhat.com>
Date: Wed, 2 Apr 2014 12:37:35 +0000 (+0200)
Subject: Fix coverity-reported leak in virSecurityManagerGenLabel
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=66050f0f892c2a62e56136d25886f8416d7881ea;p=libvirt.git

Fix coverity-reported leak in virSecurityManagerGenLabel

Coverity complains about a possible leak of seclabel if
!sec_managers[i]->drv->domainGenSecurityLabel is true
and the seclabel might be overwritten by the next iteration
of the loop.

This leak should never happen, because every security driver
has domainGenSecurityLabel defined.
---

diff --git a/src/security/security_manager.c b/src/security/security_manager.c
index d68c7e949e..79edb07e91 100644
--- a/src/security/security_manager.c
+++ b/src/security/security_manager.c
@@ -514,6 +514,8 @@ int virSecurityManagerGenLabel(virSecurityManagerPtr mgr,
 
         if (!sec_managers[i]->drv->domainGenSecurityLabel) {
             virReportUnsupportedError();
+            virSecurityLabelDefFree(seclabel);
+            seclabel = NULL;
         } else {
             /* The seclabel must be added to @vm prior calling domainGenSecurityLabel
              * which may require seclabel to be presented already */