From: Ján Tomko <jtomko@redhat.com>
Date: Fri, 20 Nov 2015 07:26:00 +0000 (+0100)
Subject: security_dac: check if virSecurityDACGetIds returns negative
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=63cc969a845cf633d45df96a7fe7f79ee461cb7e;p=people%2Fliuw%2Flibxenctrl-split%2Flibvirt.git

security_dac: check if virSecurityDACGetIds returns negative

Use the customary check '< 0' instead of checking for non-zero.

No functional change.
---

diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index cdde34ec2..6cb483949 100644
--- a/src/security/security_dac.c
+++ b/src/security/security_dac.c
@@ -547,7 +547,7 @@ virSecurityDACSetSecurityHostdevLabelHelper(const char *file,
     uid_t user;
     gid_t group;
 
-    if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL))
+    if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL) < 0)
         return -1;
 
     return virSecurityDACSetOwnership(priv, NULL, file, user, group);
@@ -1305,7 +1305,7 @@ virSecurityDACSetChildProcessLabel(virSecurityManagerPtr mgr,
 
     secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);
 
-    if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL))
+    if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL) < 0)
         return -1;
 
     VIR_DEBUG("Setting child to drop privileges to %u:%u",