From: Andrei Tatar Date: Thu, 4 May 2023 22:03:13 +0000 (+0200) Subject: Revert "Makefile.uk: Add flag to avoid gcc specifc symbol" X-Git-Tag: RELEASE-0.13.0~1 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=63ac465bc66de2e492b94de747e7ba78f853ad93;p=unikraft%2Flibs%2Fmusl.git Revert "Makefile.uk: Add flag to avoid gcc specifc symbol" This reverts commit 4912487a42ec9ab1f7ab7bcca698c50a849eafa8. __muldc3 is implemented by lib-compiler-rt for clang, and emitting calls to it is normal. While -ffast-math prevents these calls, it also enables unsafe optimizations that might result in wrong results from math functions. Signed-off-by: Andrei Tatar Reviewed-by: Maria Sfiraiala Reviewed-by: Stefan Jumarea Approved-by: Razvan Deaconescu Tested-by: Unikraft CI GitHub-Closes: #46 --- diff --git a/Makefile.uk b/Makefile.uk index 11f3971..0d66cf0 100644 --- a/Makefile.uk +++ b/Makefile.uk @@ -141,9 +141,6 @@ LIBMUSL_CFLAGS-y += -Wno-missing-braces LIBMUSL_CFLAGS-$(call gcc_version_ge,8,0) += -Wno-cast-function-type LIBMUSL_CFLAGS-y += -Wno-format-contains-nul LIBMUSL_CFLAGS-y += -Wno-type-limits -ifeq ($(CONFIG_LIBMUSL_COMPLEX),y) -LIBMUSL_CFLAGS-$(call have_clang) += -ffast-math -endif LIBMUSL_CFLAGS-y += -DUK_LIBC_SYSCALL=0 LIBMUSL_CFLAGS-y += -D_XOPEN_SOURCE=700 LIBMUSL_CFLAGS-y += $(LIBMUSL_HDRS_FLAGS-y)