From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 10 Feb 2016 16:17:00 +0000 (+0100)
Subject: storageVolCreateXMLFrom: Check if backend knows how to createVol
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=611a278fa46d3136b7fe5c6ab05e660ca3c8fdf4;p=libvirt.git

storageVolCreateXMLFrom: Check if backend knows how to createVol

It is highly unlikely that a backend will know how to create a
volume from a different volume (buildVolFrom) and not know how to
create an empty volume (createVol). But:
1) we call the function without any prior check so if that's the
case we would SIGSEGV immediatelly
2) it's better to be safe than sorry.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index e0ded01619..81b158497d 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -2037,6 +2037,13 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj,
     if (newvol->target.capacity < origvol->target.capacity)
         newvol->target.capacity = origvol->target.capacity;
 
+    if (!backend->createVol) {
+        virReportError(VIR_ERR_NO_SUPPORT,
+                       "%s", _("storage pool does not support volume "
+                               "creation"));
+        goto cleanup;
+    }
+
     if (!backend->buildVolFrom) {
         virReportError(VIR_ERR_NO_SUPPORT,
                        "%s", _("storage pool does not support"