From: John Ferlan <jferlan@redhat.com>
Date: Mon, 18 Dec 2017 12:47:30 +0000 (-0500)
Subject: conf: Use bool for @check_active parameter
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=607524af4f14c6d6e3f0693e5f8249ac6dc0b24c;p=libvirt.git

conf: Use bool for @check_active parameter

Use a bool as that's how the variable is used in the function.
---

diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c
index 19903b6c51..1eaa53423d 100644
--- a/src/conf/virstorageobj.c
+++ b/src/conf/virstorageobj.c
@@ -1133,7 +1133,7 @@ virStoragePoolObjGetNames(virStoragePoolObjListPtr pools,
 int
 virStoragePoolObjIsDuplicate(virStoragePoolObjListPtr pools,
                              virStoragePoolDefPtr def,
-                             unsigned int check_active)
+                             bool check_active)
 {
     int ret = -1;
     virStoragePoolObjPtr obj = NULL;
diff --git a/src/conf/virstorageobj.h b/src/conf/virstorageobj.h
index 4f372386af..dd7001c4b2 100644
--- a/src/conf/virstorageobj.h
+++ b/src/conf/virstorageobj.h
@@ -247,7 +247,7 @@ virStoragePoolObjRemove(virStoragePoolObjListPtr pools,
 int
 virStoragePoolObjIsDuplicate(virStoragePoolObjListPtr pools,
                              virStoragePoolDefPtr def,
-                             unsigned int check_active);
+                             bool check_active);
 
 int
 virStoragePoolObjSourceFindDuplicate(virConnectPtr conn,
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index f86087fb0f..f590f6b9be 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -656,7 +656,7 @@ storagePoolCreateXML(virConnectPtr conn,
     if (virStoragePoolCreateXMLEnsureACL(conn, newDef) < 0)
         goto cleanup;
 
-    if (virStoragePoolObjIsDuplicate(driver->pools, newDef, 1) < 0)
+    if (virStoragePoolObjIsDuplicate(driver->pools, newDef, true) < 0)
         goto cleanup;
 
     if (virStoragePoolObjSourceFindDuplicate(conn, driver->pools, newDef) < 0)
@@ -751,7 +751,7 @@ storagePoolDefineXML(virConnectPtr conn,
     if (virStoragePoolDefineXMLEnsureACL(conn, newDef) < 0)
         goto cleanup;
 
-    if (virStoragePoolObjIsDuplicate(driver->pools, newDef, 0) < 0)
+    if (virStoragePoolObjIsDuplicate(driver->pools, newDef, false) < 0)
         goto cleanup;
 
     if (virStoragePoolObjSourceFindDuplicate(conn, driver->pools, newDef) < 0)