From: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Fri, 24 May 2024 19:37:50 +0000 (+0100)
Subject: xen/bitops: Rearrange the top of xen/bitops.h
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=5f7606c048f7cca1a4301b321af70791c1d22378;p=people%2Ftklengyel%2Fxen.git

xen/bitops: Rearrange the top of xen/bitops.h

The #include <asm/bitops.h> can move to the top of the file now now that
generic_ffs()/generic_fls() have been untangled.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Release-acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---

diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h
index d216fead17..6a5e28730a 100644
--- a/xen/include/xen/bitops.h
+++ b/xen/include/xen/bitops.h
@@ -4,6 +4,8 @@
 #include <xen/compiler.h>
 #include <xen/types.h>
 
+#include <asm/bitops.h>
+
 /*
  * Create a contiguous bitmask starting at bit position @l and ending at
  * position @h. For example GENMASK(30, 21) gives us 0x7fe00000ul.
@@ -22,20 +24,6 @@
 unsigned int __pure generic_ffsl(unsigned long x);
 unsigned int __pure generic_flsl(unsigned long x);
 
-/*
- * Include this here because some architectures need generic_ffs/fls in
- * scope
- */
-
-/* --------------------- Please tidy above here --------------------- */
-
-#include <asm/bitops.h>
-
-/*
- * Find First/Last Set bit (all forms).
- *
- * Bits are labelled from 1.  Returns 0 if given 0.
- */
 static always_inline __pure unsigned int ffs(unsigned int x)
 {
     if ( __builtin_constant_p(x) )