From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 28 May 2014 09:16:59 +0000 (+0200)
Subject: qemu-io: Plug memory leak in open command
X-Git-Tag: qemu-xen-4.5.0-rc1^2~58
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=5e3322eec31e6198c5370a1f01c6e1429548ebcb;p=qemu-upstream-4.5-testing.git

qemu-io: Plug memory leak in open command

Introduced in commit b543c5c.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 29f2601aa605f0af0cba8eedcff7812c6c8532e9)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---

diff --git a/qemu-io.c b/qemu-io.c
index 5d7b53f75..bc1277d09 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -54,6 +54,7 @@ static int openfile(char *name, int flags, int growable, QDict *opts)
 
     if (qemuio_bs) {
         fprintf(stderr, "file open already, try 'help close'\n");
+        QDECREF(opts);
         return 1;
     }
 
@@ -171,6 +172,7 @@ static int open_f(BlockDriverState *bs, int argc, char **argv)
     } else if (optind == argc) {
         return openfile(NULL, flags, growable, opts);
     } else {
+        QDECREF(opts);
         return qemuio_command_usage(&open_cmd);
     }
 }