From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 24 Jun 2016 15:01:27 +0000 (+0200)
Subject: conf: Allow disks with identical WWN or serial
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=5da28cc3069b573f54f0bcaf8eb75476bcfdc6e9;p=libvirt.git

conf: Allow disks with identical WWN or serial

Disallowing them broke a use case of testing multipath configurations
for storage. Originally this was added as it was impossible to
use certain /dev/disk-by... links but the disks worked properly.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1349895
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 9443281430..79d15c8ed2 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -24906,19 +24906,8 @@ virDomainDiskDefCheckDuplicateInfo(const virDomainDiskDef *a,
         return -1;
     }
 
-    if (a->wwn && b->wwn && STREQ(a->wwn, b->wwn)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                       _("Disks '%s' and '%s' have identical WWN"),
-                       a->dst, b->dst);
-        return -1;
-    }
-
-    if (a->serial && b->serial && STREQ(a->serial, b->serial)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                       _("Disks '%s' and '%s' have identical serial"),
-                       a->dst, b->dst);
-        return -1;
-    }
+    /* Duplicate WWN/serial isn't usually problematic for the OS and
+     * forbiding it would possibly inhibit using multipath configurations */
 
     return 0;
 }