From: Andrea Bolognani <abologna@redhat.com>
Date: Fri, 20 Jul 2018 07:45:12 +0000 (+0200)
Subject: src: Use VIR_STRDUP() wherever possible
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=5d481d0d02f34a7ea822265a396973012218ad33;p=libvirt.git

src: Use VIR_STRDUP() wherever possible

virStrcpy() and friends are useful when the destination
buffer has already been allocated, eg. as part of a struct;
if we have to allocate it on the spot, VIR_STRDUP() is a
better choice.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---

diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
index 4a93f09a7d..e62ebfb596 100644
--- a/src/remote/remote_daemon_dispatch.c
+++ b/src/remote/remote_daemon_dispatch.c
@@ -2309,9 +2309,7 @@ remoteDispatchDomainGetSecurityLabelList(virNetServerPtr server ATTRIBUTE_UNUSED
     for (i = 0; i < len; i++) {
         size_t label_len = strlen(seclabels[i].label) + 1;
         remote_domain_get_security_label_ret *cur = &ret->labels.labels_val[i];
-        if (VIR_ALLOC_N(cur->label.label_val, label_len) < 0)
-            goto cleanup;
-        if (virStrcpy(cur->label.label_val, seclabels[i].label, label_len) == NULL) {
+        if (VIR_STRDUP(cur->label.label_val, seclabels[i].label) < 0) {
             virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                            _("failed to copy security label"));
             goto cleanup;