From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 19 Oct 2015 12:36:14 +0000 (+0200)
Subject: conf: Drop useless check when parsing cpu scheduler info
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=5ba01683b6882601478b24212ebbb8d6fd7e00a4;p=libvirt.git

conf: Drop useless check when parsing cpu scheduler info

The checked predicate is a deduction from the following checks:

1) maximum cpu id is checked for every parsed <vcpusched> element
2) the resulting bitmaps are checked for overlaps
3) there has to be at least one cpu per <vcpusched>

From the above checks we can indeed deduce that if we have one
<vcpusched> element per CPU we will have at most 'maxvcpus' of them.

Drop the explicit check since it's redundant.
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0ac7dbf249..616bf80acd 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -15224,12 +15224,6 @@ virDomainDefParseXML(xmlDocPtr xml,
         goto error;
     }
     if (n) {
-        if (n > def->maxvcpus) {
-            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                           _("too many vcpusched nodes in cputune"));
-            goto error;
-        }
-
         if (VIR_ALLOC_N(def->cputune.vcpusched, n) < 0)
             goto error;
         def->cputune.nvcpusched = n;