From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 30 Sep 2013 09:47:47 +0000 (+0200)
Subject: qemu: process: Silence coverity warning when rewinding log file
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=59e21e973fdbfc9065ff5aa421ae36dbd1c4073a;p=libvirt.git

qemu: process: Silence coverity warning when rewinding log file

The change in ef29de14c37d14abc546e90555a0093797facfdd that introduced
better error logging from qemu introduced a warning from coverity about
unused return value from lseek. Silence this warning and fix typo in the
corresponding error message.

Reported by: John Ferlan
---

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index d7be7319c3..7a30a5ed4e 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -1845,10 +1845,10 @@ cleanup:
         }
 
         len = strlen(buf);
-        /* best effor seek - we need to reset to the original position, so that
+        /* best effort seek - we need to reset to the original position, so that
          * a possible read of the fd in the monitor code doesn't influence this
          * error delivery option */
-        lseek(logfd, pos, SEEK_SET);
+        ignore_value(lseek(logfd, pos, SEEK_SET));
         qemuProcessReadLog(logfd, buf + len, buf_size - len - 1, 0, true);
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("process exited while connecting to monitor: %s"),